EFFECT

When another operation is used instead of = in assignment expression, the statement has no effect.

Vulnerability and risk

Potentially a critical problem.

Example 1

1  class A{
2     int foo(int);
3  };
4  int A::foo(int k){
5       int j = 1;
6       k = 0;
7       if(j){
8           j > k;  // EFFECT
9           return j;
10          }else{
11           k++;
12           return k;
13          }
14  }

Security Guidelines

• CWE-480: Use of Incorrect Operator
• CWE-482: Comparing instead of Assigning
• MSC12-C: Detect and remove code that has no effect or is never executed