Start here

Home
About Klocwork
What's new
Fixed issues
Release notes
Installation

Reference

C/C++ checkers
Java checkers
C# checkers
MISRA C 2004 checkers
MISRA C++ 2008 checkers
MISRA C 2012 checkers
MISRA C 2012 checkers with Amendment 1
Commands
Metrics
Troubleshooting
Reference

Product components

C/C++ Integration build analysis
Java Integration build analysis
Desktop analysis
Refactoring
Klocwork Static Code Analysis
Klocwork Code Review
Structure101
Tuning
Custom checkers

Coding environments

Visual Studio
Eclipse for C/C++
Eclipse for Java
IntelliJ IDEA
Other

Administration

Project configuration
Build configuration
Administration
Analysis performance
Server performance
Security/permissions
Licensing
Klocwork Static Code Analysis Web API
Klocwork Code Review Web API

Community

View help online
Visit RogueWave.com
Klocwork Support
Rogue Wave Videos

Legal

Legal information

SV.UNBOUND_STRING_INPUT.FUNC

Buffer overflow from unbounded string copy

The string copy function is used to copy a string of characters to a buffer of memory. The strcpy function has no argument to limit the size of the written data, so a buffer overflow may result.

The SV.UNBOUNDED_STRING_INPUT.FUNC checker looks for code calling insecure string copy functions that don't specify a buffer size, like gets(), gettext(), or catgets().

Vulnerability and risk

If the string copy function is called without a size parameter, a buffer overrun error can result. This can lead to application instability or, with a carefully constructed attack, code injection, or other vulnerabilities.

Mitigation and prevention

To avoid this vulnerability

  • make sure you use functions that have buffer size as an input parameter, like fgets instead of gets
  • for Windows, use StrSafe functions String*Gets, such as StringCchGets, or Safe CRT functions like gets_s
  • use a function like strlen() to determine the buffer size you need

Vulnerable code example 1

1   #include <stdio.h>
2   
3   int main()
4   {
5     char string [256];
6     printf ("Insert your full address: ");
7     gets (string);                /* SV.UNBOUND_STRING_INPUT.FUNC reported here */
8     printf ("Your address is: %s\n",string); 
9     return 0;
10  }

Fixed code example 1

1   #include <stdio.h>
2   
3   int main()
4   {
5     char string [256];
6     printf ("Insert your full address: ");
7     fgets (string, 256, stdin);    /* No checker reported because fgets considers the size of the string array */
8     printf ("Your address is: %s\n",string);
9     return 0;
10  }

Vulnerable code example 2

1   #include <stdio.h>
2   
3   int main()
4   {
5     char string [256];
6     printf ("Please Enter Your Full Name:");
7     _gettws (string);             /* SV.UNBOUND_STRING_INPUT.FUNC reported here */
8     printf ("Your Full Name Is: %s\n", string);
9     return 0;
10  }

Fixed code example 2

1   #include <stdio.h>
2   
3   int main()
4   {
5     char string [256];
6     printf ("Please Enter Your Full Name:");
7     gets_s (string, strlen(string));  /* no SV.UNBOUND_STRING_INPUT.FUNC reported here */
8     printf ("Your Full Name Is: %s\n", string);
9     return 0;
10  }