SV.PIPE.VARPotential pipe hijacking in variableIf the FILE_FLAG_FIRST_PIPE_INSTANCE parameter isn't used in the CreateNamedPipe function, the pipe can be created over an existing file, allowing a malicious user to obtain security-sensitive data or possibly execute arbitrary commands. The SV.PIPE.VAR checker finds instances in which the CreateNamedPipe function is used with a variable instead of the FILE_FLAG_FIRST_PIPE_INSTANCE parameter. Vulnerability and riskNamed pipes and shared files can compromise the system and allow unauthorized users to obtain user names of legitimate users or other sensitive information. The primary risk from this vulnerability is that a malicious user could gain additional privileges and hijack the pipe to run arbitrary programs. Mitigation and preventionUsing the FILE_FLAG_FIRST_PIPE_INSTANCE flag as the second argument in CreateNamedPipe protects against pipe highjacking attacks by ensuring that the pipe you're creating hasn't already been created. Vulnerable code example1 hPipe = CreateNamedPipe( 2 lpszPipename, // pipe name 3 mode, // read/write access 5 PIPE_TYPE_MESSAGE | // message type pipe 6 PIPE_READMODE_MESSAGE | // message-read mode 7 PIPE_WAIT, // blocking mode 8 PIPE_UNLIMITED_INSTANCES, // max. instances 9 BUFSIZE, // output buffer size 10 BUFSIZE, // input buffer size 11 0, // client time-out 12 NULL); // default security attribute Klockwork flags the variable in line 3 of the code. When the FILE_FLAG_FIRST_PIPE_INSTANCE parameter isn't used with CreateNamedPipe, it's possible for the pipe to be created over an existing file. In such a case, a malicious user could obtain security-sensitive data or possibly execute arbitrary commands. Fixed code examplehPipe = CreateNamedPipe( lpszPipename, // pipe name FILE_FLAG_FIRST_PIPE_INSTANCE | mode, // read/write access PIPE_TYPE_MESSAGE | // message type pipe PIPE_READMODE_MESSAGE | // message-read mode PIPE_WAIT, // blocking mode PIPE_UNLIMITED_INSTANCES, // max. instances BUFSIZE, // output buffer size BUFSIZE, // input buffer size 0, // client time-out NULL); // default security attribute In the fixed code example, the FILE_FLAG_FIRST_PIPE_INSTANCE is used as the second parameter in the CreateNamedPipe function, ensuring that the pipe won't be created over an existing function. Related checkersExternal guidance
|