Start here

Home
About Klocwork
What's new
Fixed issues
Release notes
Installation

Reference

C/C++ checkers
Java checkers
C# checkers
MISRA C 2004 checkers
MISRA C++ 2008 checkers
MISRA C 2012 checkers
MISRA C 2012 checkers with Amendment 1
Commands
Metrics
Troubleshooting
Reference

Product components

C/C++ Integration build analysis
Java Integration build analysis
Desktop analysis
Refactoring
Klocwork Static Code Analysis
Klocwork Code Review
Structure101
Tuning
Custom checkers

Coding environments

Visual Studio
Eclipse for C/C++
Eclipse for Java
IntelliJ IDEA
Other

Administration

Project configuration
Build configuration
Administration
Analysis performance
Server performance
Security/permissions
Licensing
Klocwork Static Code Analysis Web API
Klocwork Code Review Web API

Community

View help online
Visit RogueWave.com
Klocwork Support
Rogue Wave Videos

Legal

Legal information

NPD.FUNC.CALL.MIGHT

Possible null pointer may be dereferenced through a conditional function call

An attempt to access data using a null pointer causes a runtime error. When a program dereferences a pointer that is expected to be valid but turns out to be null, a null pointer dereference occurs. Null-pointer dereference defects often occur due to ineffective error handling or race conditions, and typically cause abnormal program termination. Before a pointer is dereferenced in C/C++ code, it must be checked to confirm that it is not equal to null.

The NPD checkers look for instances in which a null or possibly null pointer is dereferenced.

The NPD.FUNC.CALL.MIGHT checker flags situations in which a pointer value from a function call that might return null might subsequently be passed to a function that might dereference it without checking it for null.

Vulnerability and risk

Null-pointer dereferences usually result in the failure of the process. These issues typically occur due to ineffective exception handling.

Mitigation and prevention

To avoid this vulnerability:

  • Check for a null value in the results of all functions that return values
  • Make sure all external inputs are validated
  • Explicitly initialize variables
  • Make sure that unusual exceptions are handled correctly

Vulnerable code example

1  void reassign(int *argument, int *p) {
2    if (goodEnough(argument)) return;
3    *argument = *p;
4  }
5  
6  int *mymalloc() {
7    int *res = malloc(sizeof(int));
8    if (!res) return 0;
9    *res = 0;
10   return res;
11 }
12 
13 void npd_func_call_might(int *argument) {
14   int *p = mymalloc();
15   if (someCondition()){
16     p = f();
17   }
18   reassign(argument, p);
19 }

Depending on the result of the conditional statement at line 8, a null pointer may be passed to function npd_func_call_might, in which it may be dereferenced, depending on the condition at line 15. This type of vulnerability can produce unexpected and unintended results.

Fixed code example

1  void reassign(int *argument, int *p) {
2    if (goodEnough(argument)) return;
3    *argument = *p;
4  }
5  
6  int *mymalloc() {
7    int *res = malloc(sizeof(int));
8    if (!res) return 0;
9    *res = 0;
10   return res;
11 }
12 
13 void npd_func_call_might(int *argument) {
14   int *p = mymalloc();
15   if (someCondition()){
16     p = f();
17   }
18   if (p!= 0) reassign(argument, p);
19 }

In the fixed code, *p is checked for null in line 18 before the dereference.

Extension

This checker can be extended through the Klocwork knowledge base. See Tuning C/C++ analysis for more information.