Start here

Home
About Klocwork
What's new
Fixed issues
Release notes
Installation

Reference

C/C++ checkers
Java checkers
C# checkers
MISRA C 2004 checkers
MISRA C++ 2008 checkers
MISRA C 2012 checkers
MISRA C 2012 checkers with Amendment 1
Commands
Metrics
Troubleshooting
Reference

Product components

C/C++ Integration build analysis
Java Integration build analysis
Desktop analysis
Refactoring
Klocwork Static Code Analysis
Klocwork Code Review
Structure101
Tuning
Custom checkers

Coding environments

Visual Studio
Eclipse for C/C++
Eclipse for Java
IntelliJ IDEA
Other

Administration

Project configuration
Build configuration
Administration
Analysis performance
Server performance
Security/permissions
Licensing
Klocwork Static Code Analysis Web API
Klocwork Code Review Web API

Community

View help online
Visit RogueWave.com
Klocwork Support
Rogue Wave Videos

Legal

Legal information

JD.LIST.ADD

JD.LIST.ADD occurs when an operation is performed on a container, for example, addAll, removeAll, retainAll or containsAll, but the argument is a container itself. This is definitely a typo.

Vulnerability and risk

This is not an error in itself, but since it makes no sense, there is an error in the logic. For example, instead of writing con1.addAll(con2), the programmer wrote con1.addAll(con1). The severity of this error depends on where and how the code is used.

Mitigation and prevention

Fix the name of the method argument or, perhaps, replace removeAll with list.clean().

Example 1

11     private Collection foo(Collection list12_3,
12                            Collection list12_4) {
13         if (list12_3.size() < list12_4.size()) {
14             list12_3.addAll(list12_4);
15             return list12_3;
16         } else {
17             list12_4.addAll(list12_4);
18             return list12_4;
19         }
20 
21     }

JD.LIST.ADD is reported for 'addAll' call on line 17 : Container 'list12_4' calls 'addAll' with itself as an argument. This code does nothing, or there is simpler way to do it. Probably a typo.